On Thu, 15 Jan 2026 02:28:01 GMT, Alexey Semenyuk <[email protected]> wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8374215: [macos] Clean lic_template.plist [v4]
>
> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgPackager.java
> line 190:
>
>> 188: if (pkg.licenseFile().isPresent()) {
>> 189:
>> MacDmgLicense.prepareLicensePListFile(pkg.licenseFile().get(),
>> licensePListFile());
>> 190: }
>
> Isn't the following easier to read?
>
> pkg.licenseFile().ifPresent(licenseFile -> {
> MacDmgLicense.prepareLicensePListFile(licenseFile, licensePListFile());
> });
We should catch exception, so not sure if it is easy to read. I do not have
exact opinion on this one. If you think it is better to use `ifPresent` I will
change it.
pkg.licenseFile().ifPresent(licenseFile -> {
try {
MacDmgLicense.prepareLicensePListFile(licenseFile,
licensePListFile());
} catch (IOException ex) {
throw new UncheckedIOException(ex);
}
});
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28959#discussion_r2692755753
