On Thu, 15 Jan 2026 02:27:41 GMT, Alexander Matveev <[email protected]> 
wrote:

>> - Fixed plist file so translation works. It did not worked before.
>> - All strings which needs translations moved to .properties files.
>> - Added translated strings, since it is required to have all of them. We 
>> cannot have English strings in localized files, since different charset is 
>> required for each language.
>> - I tested all translations.
>> - Adding same license text for all translations is required.
>> - See JBS for screenshot of dialog. It is same except it now has drop down 
>> box with 4 languages we support. There are no way to remove it once 
>> translations implemented correctly in plist file.
>> - NOTE: License dialog for DMG was deprecated since macOS 12. Also, there 
>> are no alternative for it.
>
> Alexander Matveev has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8374215: [macos] Clean lic_template.plist [v4]

Marked as reviewed by asemenyuk (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/28959#pullrequestreview-3663715001

Reply via email to