On Wed, 21 Jan 2026 19:39:49 GMT, Weijun Wang <[email protected]> wrote:

>> Rewrite the native calls with FFM.
>
> Weijun Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   unnecessary initialization

The test has passed on linux PPC64le and AIX. @offamitkumar: Do you want to run 
the test on s390?
I think it's good.
The JBS issue says "See if it's a better alternative of JNI." Is there any 
comparison or evaluation planned?

src/jdk.security.auth/share/classes/com/sun/security/auth/module/UnixSystem.java
 line 118:

> 116:             = LINKER.downcallHandle(SYMBOL_LOOKUP.findOrThrow(
> 117:                             OperatingSystem.isAix() ? 
> "_posix_getpwuid_r" : "getpwuid_r"),
> 118:                     FunctionDescriptor.of(C_INT,

Indentation could be improved, here.

-------------

PR Review: https://git.openjdk.org/jdk/pull/28931#pullrequestreview-3689250234
PR Review Comment: https://git.openjdk.org/jdk/pull/28931#discussion_r2714211087

Reply via email to