On Wed, 21 Jan 2026 20:23:25 GMT, Martin Doerr <[email protected]> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> unnecessary initialization > > src/jdk.security.auth/share/classes/com/sun/security/auth/module/UnixSystem.java > line 118: > >> 116: = LINKER.downcallHandle(SYMBOL_LOOKUP.findOrThrow( >> 117: OperatingSystem.isAix() ? >> "_posix_getpwuid_r" : "getpwuid_r"), >> 118: FunctionDescriptor.of(C_INT, > > Indentation could be improved, here. Do you have a suggestion? I intentionally indented based on argument nesting. `FunctionDescriptor.of(...` is the 2nd argument of `downcallHandle` so I indented one level (8 spaces) to the method. `OperatingSystem.isAix()...` is argument of `findOrThrow` and `calling_convention_requires_int_as_long...` etc are arguments of `FunctionDescriptor.of` and they are indented one level further. IntelliJ IDEA unindents the `FunctionDescriptor.of(...)` block but I don't think that's correct. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28931#discussion_r2714326021
