> Hi all, > > Test java/lang/ProcessBuilder/PipelineLeaksFD.java intermittent timed out, > because `lsof` invoke huast lots of time when the tested machine has many > processes, and the processes open too many files. > > This PR add parameter -p pid to `lsof`, which will only generate output from > the wanted processes, rather than all the processes on the machine, this will > make `lsof` use less time to finish significantly. And this PR also use > `Process.waitFor(long timeout, TimeUnit unit)` instead of `waitFor()` which > will avoid waitFor invoke cause test timed out. Delete the history lsof input > and output files will make diagnosis more easy. > > Change has been verifed locally. The imtermittent timed out do not observed > anymore.
SendaoYan has updated the pull request incrementally with two additional commits since the last revision: - Revert the change of lsof -p and only increase timeout value for test - Revert "8376630: java/lang/ProcessBuilder/PipelineLeaksFD.java intermittent timed out" This reverts commit 23d6dd1ae20bdd8957826f443a95bd4e69000eab. ------------- Changes: - all: https://git.openjdk.org/jdk/pull/29478/files - new: https://git.openjdk.org/jdk/pull/29478/files/23d6dd1a..c4522418 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=29478&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29478&range=00-01 Stats: 22 lines in 1 file changed: 0 ins; 11 del; 11 mod Patch: https://git.openjdk.org/jdk/pull/29478.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29478/head:pull/29478 PR: https://git.openjdk.org/jdk/pull/29478
