On Tue, 3 Feb 2026 02:41:41 GMT, SendaoYan <[email protected]> wrote: >> Hi all, >> >> Test java/lang/ProcessBuilder/PipelineLeaksFD.java intermittent timed out, >> because `lsof` invoke huast lots of time when the tested machine has many >> processes, and the processes open too many files. >> >> This PR add parameter -p pid to `lsof`, which will only generate output from >> the wanted processes, rather than all the processes on the machine, this >> will make `lsof` use less time to finish significantly. And this PR also use >> `Process.waitFor(long timeout, TimeUnit unit)` instead of `waitFor()` which >> will avoid waitFor invoke cause test timed out. Delete the history lsof >> input and output files will make diagnosis more easy. >> >> Change has been verifed locally. The imtermittent timed out do not observed >> anymore. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > Remove retry on destroyForcibly
Looks fine; thanks for the updates. ------------- Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29478#pullrequestreview-3747265316
