On Mon, 2 Feb 2026 20:38:07 GMT, Alexey Semenyuk <[email protected]> wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8357404: jpackage should attempt to get a package version from the JDK's
>> release file if the --version option is not specified [v6]
>
> test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/util/RuntimeVersionReaderTest.java
> line 41:
>
>> 39: import org.junit.jupiter.api.io.TempDir;
>> 40:
>> 41: public class RuntimeVersionReaderTest {
>
> I doubt this unit test has ever been executed.
Confused. I did run it manually. Test works as expected.
jtreg -w build/jtreg/work -r build/jtreg/report -jdk
build/macosx-x64/images/jdk
open/test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/util/RuntimeVersionReaderTest.java
Test results: passed: 1
Framework-based tests: 3 = 0 TestNG + 3 JUnit
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29260#discussion_r2761452605
