On Wed, 4 Feb 2026 03:48:23 GMT, Alexey Semenyuk <[email protected]> wrote:
>> This function is being called 3 times already. I think having platform >> specific code in it is better, then duplicating: >> >> RuntimeImageUtils.getReleaseFilePath(MacBundle.fromPath(cookedRuntime).map(MacBundle::homeDir).orElse(cookedRuntime)); >> >> I do like idea of using `MacBundle.fromPath()`. > > The code that finds the JDK image directory in a random path is a separate > function. > The function that returns a path to the "release" file in the JDK image > should take a path to the JDK image directory. > > If we need a convenience function that does both things, we should implement > it on top of these two functions. I will just use two function. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29260#discussion_r2765868489
