On Sun, 18 Jan 2026 05:17:40 GMT, Alexander Matveev <[email protected]> 
wrote:

>> - Version will be read from JDK's release file if not provided via 
>> `--version` for runtime installer.
>> - Added test to cover added functionality.
>> - On macOS and Windows version from JDK's release file will be normalized if 
>> it does not fit platform requirements.
>
> Alexander Matveev has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8357404: jpackage should attempt to get a package version from the JDK's 
> release file if the --version option is not specified [v6]

test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/util/RuntimeVersionReaderTest.java
 line 44:

> 42: 
> 43:     @Test
> 44:     public void test_release_file_with_version(@TempDir Path workdir) {

Should we test other values of the "JAVA_VERSION" property? Empty one, some 
unexpected one, like "foo"?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29260#discussion_r2761990169

Reply via email to