On Wed, 11 Feb 2026 20:12:19 GMT, Alexander Matveev <[email protected]> wrote:
>> - Version will be read from JDK's release file if not provided via >> `--version` for runtime installer. >> - Added test to cover added functionality. >> - On macOS and Windows version from JDK's release file will be normalized if >> it does not fit platform requirements. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8357404: jpackage should attempt to get a package version from the JDK's > release file if the --version option is not specified [v9] src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinFromOptions.java line 142: > 140: // We should drop any characters. For example: "-ea". > 141: return ver.toComponentsString(); > 142: } If I understand the code correctly, and the `version` variable is set to "17.2", then the function will return "17.2", right? But if it is "17.2.1", it will return "17.2.1.0". Is this what we want? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29260#discussion_r2800695743
