On Thu, 5 Feb 2026 15:35:56 GMT, Alexey Semenyuk <[email protected]> wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8357404: jpackage should attempt to get a package version from the JDK's
>> release file if the --version option is not specified [v8]
>
> test/jdk/tools/jpackage/share/NoMPathRuntimeTest.java line 99:
>
>> 97:
>> Files.createDirectories(workDir.resolve("Contents/MacOS"));
>> 98: }
>> 99: }
>
> I don't understand the comment. Why is this change?
`MacBundle.fromPath()` will fail if we do not have at least "Contents/Home",
"Contents/Info.plist" and "Contents/MacOS". `ModuleInfo.fromCookedRuntime()`
will be called from this test and it will fail as a result, since
`MacBundle.fromPath()` will consider provided by test runtime as image.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29260#discussion_r2784845661
