On Thu, 12 Feb 2026 03:22:57 GMT, Kirill Shirokov <[email protected]> wrote:

> The fix removes duplicate `-agent...` and `-javaagent:...` options from test 
> subprocess command line, thus allowing to run jtreg tests with agents that 
> should be specified only once.
> 
> The fix tested manually:
> 
> 
> $ make test JTREG="VERBOSE=summary,fail,error" 
> TEST="test/jdk/sun/tools/jstack/DeadlockDetectionTest.java 
> test/hotspot/jtreg/compiler/jvmci/events/JvmciShutdownEventTest.java 
> test/hotspot/jtreg/gc/g1/ihop/TestIHOPStatic.java"
> 
> ==============================
> Test summary
> ==============================
>    TEST                                              TOTAL  PASS  FAIL ERROR  
> SKIP
>    jtreg:test/jdk/sun/tools/jstack/DeadlockDetectionTest.java
>                                                          1     1     0     0  
>    0
>    jtreg:test/hotspot/jtreg/compiler/jvmci/events/JvmciShutdownEventTest.java
>                                                          1     1     0     0  
>    0
>    jtreg:test/hotspot/jtreg/gc/g1/ihop/TestIHOPStatic.java
>                                                          1     1     0     0  
>    0
> ==============================
> TEST SUCCESS
> 
> $ make test 
> JTREG="VERBOSE=summary,fail,error;JAVA_OPTIONS=-agentpath.../async-profiler-binaries/lib/libasyncProfiler.dylib=start,event=cpu,cstack=vm,loglevel=none,flat,file=/dev/null"
>  TEST="test/jdk/sun/tools/jstack/DeadlockDetectionTest.java 
> test/hotspot/jtreg/compiler/jvmci/events/JvmciShutdownEventTest.java 
> test/hotspot/jtreg/gc/g1/ihop/TestIHOPStatic.java"
> 
> ==============================
> Test summary
> ==============================
>    TEST                                              TOTAL  PASS  FAIL ERROR  
> SKIP
>    jtreg:test/jdk/sun/tools/jstack/DeadlockDetectionTest.java
>>>                                                       1     0     1     0   
>>>   0 <<
>    jtreg:test/hotspot/jtreg/compiler/jvmci/events/JvmciShutdownEventTest.java
>>>                                                       1     0     1     0   
>>>   0 <<
>    jtreg:test/hotspot/jtreg/gc/g1/ihop/TestIHOPStatic.java
>>>                                                       1     0     1     0   
>>>   0 <<
> ==============================
> TEST FAILURE
> 
> $ make test 
> JTREG="VERBOSE=summary,fail,error;VM_OPTIONS=-agentpath:.../async-profiler-binaries/lib/libasyncProfiler.dylib=start,event=cpu,cstack=vm,loglevel=none,flat,file=/dev/null"
>  TEST="test/jdk/sun/tools/jstack/DeadlockDetectionTest.java 
> test/hotspot/jtreg/compiler/jvmci/events/JvmciShutdownEventTest.java 
> test/hotspot/jtreg/gc/g1/ihop/TestIHOPStatic.java"
> 
> (same errors)
> 
> With th...

This pull request has now been integrated.

Changeset: f02d1900
Author:    Kirill Shirokov <[email protected]>
Committer: Leonid Mesnik <[email protected]>
URL:       
https://git.openjdk.org/jdk/commit/f02d1900958ee705c4e86bc94b92f7c2cde39c0d
Stats:     40 lines in 5 files changed: 30 ins; 4 del; 6 mod

8377729: Running jtreg tests with -agent... option causes some tests to fail 
due to duplicate -agent options provided to a subprocess

Reviewed-by: lmesnik, sspitsyn

-------------

PR: https://git.openjdk.org/jdk/pull/29684

Reply via email to