On Wed, 18 Feb 2026 10:42:01 GMT, David Beaumont <[email protected]> wrote:
> Removed the manual file tidyup on the expectation that jtreg will sort that
> all out.
> Switched to using Utils.createTempFile() while I was there.
Good to clean up the CI.
test/jdk/tools/jimage/JImageBadFileTest.java line 145:
> 143: // Self test that the file copying isn't itself corrupting
> anything.
> 144: Path tempJimage = writeModifiedJimage("good_file", -1, b -> {});
> 145: jimage("info", tempJimage.toString()).assertSuccess();
I know its a bit late to complain now, but "jimage" is not a very nor a very
descriptive name of a central utility method.
-------------
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29783#pullrequestreview-3841592785
PR Review Comment: https://git.openjdk.org/jdk/pull/29783#discussion_r2841339788
