On Mon, 23 Feb 2026 15:00:11 GMT, Roger Riggs <[email protected]> wrote:
>> Removed the manual file tidyup on the expectation that jtreg will sort that
>> all out.
>> Switched to using Utils.createTempFile() while I was there.
>
> test/jdk/tools/jimage/JImageBadFileTest.java line 145:
>
>> 143: // Self test that the file copying isn't itself corrupting
>> anything.
>> 144: Path tempJimage = writeModifiedJimage("good_file", -1, b -> {});
>> 145: jimage("info", tempJimage.toString()).assertSuccess();
>
> I know its a bit late to complain now, but "jimage" is not a very nor a very
> descriptive name of a central utility method.
It's a method on JImageCliTest, the super class of the tests for the jimage
tool.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29783#discussion_r2841476475
