On Wed, 25 Feb 2026 08:11:41 GMT, SendaoYan <[email protected]> wrote:

>> Justin Lu has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   get rid of inheritance + zip -> ZIP
>
> test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarHttpProperties.java line 
> 72:
> 
>> 70: 
>> 71:     @BeforeAll
>> 72:     public void initialize() throws Exception {
> 
> Maybe we should add `static` modifier for @BeforeAll and @AfterAll method

These methods appear like they should be `static` but since this test class 
uses a `PER_CLASS` lifecycle, these methods are actually fine as instance 
methods.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29828#discussion_r2854535843

Reply via email to