On Fri, 27 Feb 2026 18:47:00 GMT, Lance Andersen <[email protected]> wrote:

>> Justin Lu has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   get rid of inheritance + zip -> ZIP
>
> test/jdk/java/util/jar/TestJarExtra.java line 77:
> 
>> 75:     @Test
>> 76:     void jarExtraHeaderOnlyTest() throws IOException {
>> 77:         testHeaderOnly();
> 
> Any reason not to  collapse testHeaderOnly into this test method vs calling 
> it as I did not see it called twice unless I missed it

Thanks for reviewing Lance. The extra test methods were remnants from the 
testing structure in previous commits, the indirection can be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29828#discussion_r2865929115

Reply via email to