On Thu, 12 Mar 2026 11:09:36 GMT, David Beaumont <[email protected]> wrote:

>> src/hotspot/share/runtime/arguments.cpp line 2995:
>> 
>>> 2993: 
>>> 2994:   // Called after ClassLoader::lookup_vm_options() but before class 
>>> loading begins.
>>> 2995:   // TODO: Obtain and pass correct preview mode flag value here.
>> 
>> Suggestion: A hotspot convention is to include the bugid of the 
>> fix/enhancement that is pending.
>> Since you've planned the progression of PR's that may be useful here.  YMMV.
>
> And I've also been told at least once that we're not to add bug numbers into 
> code. I don't have the other PR created yet either, and it will all be forced 
> when the other code arrives due to tests anyway.

When is this To-Do turning up? Why isn't it being done here in this PR?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29414#discussion_r2929330124

Reply via email to