On Tue, 3 Feb 2026 11:43:07 GMT, David Beaumont <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More feedback tweaks
>
> src/hotspot/share/classfile/classLoader.cpp line 246:
>
>> 244: jint error;
>> 245: JImage_file = (*JImageOpen)(modules_path, &error);
>> 246: if (Arguments::has_jimage() && JImage_file == nullptr) {
>
> Error check added to mainline but refactored here for simplicity (these
> functions are intended to encapsulate this sort of thing).
Is `error` intended to give more information about what went wrong opening the
JImage file i.e. used just to add information to the vm_exit message?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29414#discussion_r2929348641
