On Fri, 13 Mar 2026 06:30:37 GMT, David Holmes <[email protected]> wrote:
>> src/hotspot/share/classfile/classLoader.cpp line 246:
>>
>>> 244: jint error;
>>> 245: JImage_file = (*JImageOpen)(modules_path, &error);
>>> 246: if (Arguments::has_jimage() && JImage_file == nullptr) {
>>
>> Error check added to mainline but refactored here for simplicity (these
>> functions are intended to encapsulate this sort of thing).
>
> Is `error` intended to give more information about what went wrong opening
> the JImage file i.e. used just to add information to the vm_exit message?
It would be, but it's just never set to anything useful (this is an existing
issue with the mainline code too that this code is refactoring).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29414#discussion_r2930254609
