On Mon, 16 Mar 2026 22:42:48 GMT, Naoto Sato <[email protected]> wrote:

>> Converting two TestNG tests in that directory to JUnit
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   copyright year

test/jdk/java/lang/Character/Latin1CaseConversion.java line 26:

> 24: import static org.junit.jupiter.api.Assertions.assertEquals;
> 25: import static org.junit.jupiter.api.Assertions.fail;
> 26: import org.junit.jupiter.api.Test;

Same comment about order of static imports.

test/jdk/java/lang/Character/UnicodeBlock/NumberEntities.java line 34:

> 32:  */
> 33: 
> 34: import static org.junit.jupiter.api.Assertions.assertEquals;

I think by convention we usually put the static imports after the non-static 
ones.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30272#discussion_r2943366524
PR Review Comment: https://git.openjdk.org/jdk/pull/30272#discussion_r2943364695

Reply via email to