On Mon, 16 Mar 2026 23:15:23 GMT, Chen Liang <[email protected]> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reordered imports > > test/jdk/java/lang/Character/UnicodeBlock/NumberEntities.java line 49: > >> 47: n.setAccessible(true); >> 48: m.setAccessible(true); >> 49: assertEquals(n.getInt(null), ((Map)m.get(null)).size()); > > I think using the map's size as source of truth (expected) is better as the > int field is more like duplicated data derived from the map Hmm, I think the constant number is the "expected" number, even though it is derived from the map. (Theoretically it can be truthfully derived from the Unicode database only) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30272#discussion_r2943598819
