On Wed, 18 Mar 2026 18:01:54 GMT, Justin Lu <[email protected]> wrote:
>> In the java/io tests, replace the TestNG framework with JUnit. > > test/jdk/java/io/ByteArrayOutputStream/Write.java line 116: > >> 114: byte[] b1 = baos.toByteArray(); >> 115: assertEquals(len1, b1.length, "Array length test 1 failed."); >> 116: assertArrayEquals(b1, Arrays.copyOfRange(b, off1, off1 + len1), > > For these new `assertArrayEquals` cases, I think we will want to swap the > args to match the original expected vs actual positioning. Missed those, thanks. > test/jdk/java/io/OutputStream/NullOutputStream.java line 31: > >> 29: import org.junit.jupiter.api.Test; >> 30: >> 31: import static org.junit.jupiter.api.Assertions.assertArrayEquals; > > Most of these imports look unneeded for this test. Right, thanks. > test/jdk/java/io/Reader/ReadIntoZeroLengthArray.java line 53: > >> 51: private char[] cbuf1; >> 52: >> 53: @BeforeAll > > `setup` and `teardown` need to be static. Agreed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30289#discussion_r2956812530 PR Review Comment: https://git.openjdk.org/jdk/pull/30289#discussion_r2956812103 PR Review Comment: https://git.openjdk.org/jdk/pull/30289#discussion_r2956811747
