On Thu, 19 Mar 2026 00:18:29 GMT, Brian Burkhalter <[email protected]> wrote:

>> In the java/io tests, replace the TestNG framework with JUnit.
>
> Brian Burkhalter has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8379824: Address most reviewer comments

test/jdk/java/io/Reader/ReadIntoZeroLengthArray.java line 74:

> 72:     }
> 73: 
> 74:     @ParameterizedTest(autoCloseArguments=false)

`autoCloseArguments=false` is probably needed since a single `fileReader` is 
reused as argument, but could that then cause `file.delete()` to (silently) 
fail because the reader is still open?

Would an alternative be to create separate `FileReader` instances for each 
argument, and removing `autoCloseArguments=false`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30289#discussion_r2959705945

Reply via email to