On Sat, 21 Mar 2026 08:30:42 GMT, Alan Bateman <[email protected]> wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Using Class.getPackageName + Class.getClassLoader to detect runtime >> packages as suggested. > > src/java.base/share/classes/jdk/internal/misc/MethodFinder.java line 114: > >> 112: return Objects.equals(c1.getPackageName(), c2.getPackageName()) >> && >> 113: Objects.equals(c1.getClassLoader(), c2.getClassLoader()); >> 114: } > > The application class loader is well behaved so it doesn't matter too much > but it would be better to check that c1.getClassLoader() == > c2.getClassLoader(). Right, fixed (https://github.com/openjdk/jdk/pull/30221/commits/dcc393f33ec03d5db24e611a2ff20ba880aea3bb). Thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30221#discussion_r2975605063
