On Mon, 23 Mar 2026 14:57:59 GMT, Jan Lahoda <[email protected]> wrote:
>> src/java.base/share/classes/jdk/internal/misc/MethodFinder.java line 114: >> >>> 112: return Objects.equals(c1.getPackageName(), >>> c2.getPackageName()) && >>> 113: Objects.equals(c1.getClassLoader(), >>> c2.getClassLoader()); >>> 114: } >> >> The application class loader is well behaved so it doesn't matter too much >> but it would be better to check that c1.getClassLoader() == >> c2.getClassLoader(). > > Right, fixed > (https://github.com/openjdk/jdk/pull/30221/commits/dcc393f33ec03d5db24e611a2ff20ba880aea3bb). > Thanks! Thanks, I think the change looks okay now. I can't think of anything that could be relying on the existing behavior so I don't think the compatible/behavior-change is a significant concern. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30221#discussion_r2976062358
