On Mon, 23 Mar 2026 15:24:22 GMT, Alexey Semenyuk <[email protected]> wrote:
>> Support the use of "--mac-app-store" option when signing predefined app
>> image.
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit since the last revision:
>
> LauncherVerifier: log message reworded
If I remember correctly we used to read app store value from `.jpackage.xml`
when doing predefined app image signing to figure out how we should sign it.
What is good reason to sign predefined app image for app store if it was not
generated for app store?
src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacFromOptions.java line
278:
> 276: appStore = MAC_APP_STORE.getFrom(appImageFileOptions);
> 277: } else {
> 278: appStore = false;
I do not see any difference between old and new code. Can you explain?
test/jdk/tools/jpackage/macosx/SigningAppImageTest.java line 67:
> 65: var testAL = new AdditionalLauncher("testAL");
> 66: testAL.applyTo(cmd);
> 67: cmd.executeAndAssertHelloAppImageCreated();
Why it is removed?
-------------
PR Review: https://git.openjdk.org/jdk/pull/30346#pullrequestreview-3995272172
PR Review Comment: https://git.openjdk.org/jdk/pull/30346#discussion_r2978083417
PR Review Comment: https://git.openjdk.org/jdk/pull/30346#discussion_r2978171970
