On Mon, 23 Mar 2026 22:58:16 GMT, Alexander Matveev <[email protected]> 
wrote:

>> Alexey Semenyuk has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   LauncherVerifier: log message reworded
>
> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacFromOptions.java 
> line 278:
> 
>> 276:             appStore = MAC_APP_STORE.getFrom(appImageFileOptions);
>> 277:         } else {
>> 278:             appStore = false;
> 
> I do not see any difference between old and new code. Can you explain?

The old code read the "app-store" property from the predefined image and 
ignored the value specified on the command line. The new code reads "app-store" 
property from the command line first. If not found, it reads it from the 
predefined image.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30346#discussion_r2978317704

Reply via email to