On Thu, 14 May 2026 09:10:11 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add @ValueBased to FunctionDescriptorImpl
>> - Revert the change in FunctionDescriptor
>
> src/java.base/share/classes/java/lang/foreign/FunctionDescriptor.java line 46:
>
>> 44: * @implSpec
>> 45: * Implementing classes are immutable, thread-safe and
>> 46: * <a
>> href="{@docRoot}/java.base/java/lang/doc-files/ValueBased.html">value-based</a>.
>
> Shouldn't this use the `@ValueBased` anno instead?
(I know this is slightly outside the scope of the PR -- but since we're here
and the discussion is fresh...)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30481#discussion_r3240305429
