On Mon, 8 Jun 2026 17:52:24 GMT, Alan Bateman <[email protected]> wrote:
>> Dusan Balek has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Following reviewver comments
>
> test/langtools/tools/javac/SystemFilesClosed.java line 73:
>
>> 71: }
>> 72: Files.copy(jrtfsPath, target.resolve("jrt-fs.jar"),
>> StandardCopyOption.REPLACE_EXISTING);
>> 73: Files.copy(modulesPath, target.resolve("modules"),
>> StandardCopyOption.REPLACE_EXISTING);
>
> Did you consider just invoking jlink to create a target image, e.g.
>
> java.util.spi.ToolProvider.findFirst("jlink")
> .orElseThrow()
> .run(System.out, System.err, "--add-modules", "java.base", "--output",
> "testimage")
>
> That would avoid the test needing to know/copy lib/modules and lib/jrt-fs.jar.
Done. Thanks for pointing this out.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31417#discussion_r3379433964
