On Tue, 9 Jun 2026 11:25:26 GMT, Alan Bateman <[email protected]> wrote:

>> Dusan Balek has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Real path used as filter
>
> test/langtools/tools/javac/SystemFilesClosed.java line 59:
> 
>> 57:     void testSystemFilesClosed() throws Exception {
>> 58:         String targetSystem = base.toString();
>> 59:         try (PrintStream err = new 
>> PrintStream(OutputStream.nullOutputStream())) {
> 
> Why is stderr going to the equivalent of /dev/null? I would think it would be 
> better to invoke jlink with the current System.out and System.err so that the 
> output/error goes to the .jtr file.

I just wanted to prevent the test from failing when run on an exploded build. 
However, you are right that there is no harm in having the error reported in 
the .jtr file.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31417#discussion_r3381160660

Reply via email to