On Thu, 18 Jun 2026 15:42:06 GMT, Erik Joelsson <[email protected]> wrote:
>> BUILD_LIBZIP_EXCLUDES is set but never used, this looks wrong. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > make/modules/java.base/lib/CoreLibraries.gmk line 80: > >> 78: >> ################################################################################ >> 79: >> 80: BUILD_LIBZIP_EXCLUDES := > > It looks like it intended to initialize `LIBZIP_EXCLUDES` to empty before > building on it in the conditional. Yeah this could be the case ! Should I adjust the init ? Btw is there a rule to do these empty-inits in the makefiles ? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31570#discussion_r3440663491
