On Fri, 19 Jun 2026 06:32:09 GMT, Matthias Baesken <[email protected]> wrote:
>> make/modules/java.base/lib/CoreLibraries.gmk line 80: >> >>> 78: >>> ################################################################################ >>> 79: >>> 80: BUILD_LIBZIP_EXCLUDES := >> >> It looks like it intended to initialize `LIBZIP_EXCLUDES` to empty before >> building on it in the conditional. > > Yeah this could be the case ! Should I adjust the init ? > Btw is there a rule to do these empty-inits in the makefiles ? It's generally good to initialize to empty first to avoid accidentally picking up unexpected values from the environment. There are also exceptions where we add to variables that may have been defined in custom makefiles. We try to document such cases with comments. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31570#discussion_r3450258320
