On Tue, 30 Jun 2026 02:32:50 GMT, Chen Liang <[email protected]> wrote:
>> April Ivy has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new commit since the last revision:
>>
>> 8386802: ClassFile Util.entryList should consider non-RandomAccess lists
>
> test/jdk/jdk/classfile/UtilTest.java line 166:
>
>> 164: }
>> 165:
>> 166: private static final class GetCountingList<T> extends
>> AbstractList<T> {
>
> I don't think we need to verify the functionality here; I marked this as
> noreg-perf meaning this is some minor performance tuning that does not need
> extra regression tests (because there is no regression in the first place)
>
> You can just rollback all the test changes.
Thanks, updated in the latest push.
I removed the indexed/get path and kept the iterator loop. I also rolled back
the UtilTest changes as suggested. I applied the same simplification to
moduleEntryList since it had the same access pattern.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31719#discussion_r3499694317
