On Tue, 30 Jun 2026 15:13:35 GMT, ExE Boss <[email protected]> wrote: >> April Ivy has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new commit since the last revision: >> >> 8386802: ClassFile Util.entryList should consider non-RandomAccess lists > > src/java.base/share/classes/jdk/internal/classfile/impl/Util.java line 204: > >> 202: for (var entry : list) { >> 203: result[i++] = TemporaryConstantPool.INSTANCE.moduleEntry( >> 204: >> TemporaryConstantPool.INSTANCE.utf8Entry(entry.name())); > > This can just call the [`ConstantPoolBuilder::moduleEntry(ModuleDesc)`] > overload instead, matching `Util::entryList(…)` above: > Suggestion: > > result[i++] = TemporaryConstantPool.INSTANCE.moduleEntry(entry); > > > [`ConstantPoolBuilder::moduleEntry(ModuleDesc)`]: > https://docs.oracle.com/en/java/javase/26/docs/api/java.base/java/lang/classfile/constantpool/ConstantPoolBuilder.html#moduleEntry(java.lang.constant.ModuleDesc)
Thanks, updated in the latest push. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31719#discussion_r3500027716
