On Tue, 7 Jul 2026 20:47:42 GMT, Daisuke Yamazaki <[email protected]> wrote:
>> Added a fast path for `PriorityQueue#addAll` when adding elements to an >> empty, exact `PriorityQueue` instance. >> >> Instead of inserting each element one by one through `AbstractQueue#addAll`, >> the implementation now copies the source collection into the backing array >> and calls `heapify()`. >> This reduces the construction cost for bulk insertion into an empty queue >> from repeated per-element sift-up work to linear-time heap construction. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Daisuke Yamazaki has updated the pull request incrementally with one > additional commit since the last revision: > > Revert redundant styling src/java.base/share/classes/java/util/PriorityQueue.java line 378: > 376: int len = es.length; > 377: if (len == 0) > 378: return false; I don't see that we need to prepareElements and then make the emptiness check. If `c` is `exactly PriorityQueue.class` then we should be able to trust `c.isEmpty()` and not even call prepareElements if it is true. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31701#discussion_r3542835868
