On Wed, 8 Jul 2026 10:43:51 GMT, Daisuke Yamazaki <[email protected]> wrote:
>> Added a fast path for `PriorityQueue#addAll` when adding elements to an >> empty, exact `PriorityQueue` instance. >> >> Instead of inserting each element one by one through `AbstractQueue#addAll`, >> the implementation now copies the source collection into the backing array >> and calls `heapify()`. >> This reduces the construction cost for bulk insertion into an empty queue >> from repeated per-element sift-up work to linear-time heap construction. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Daisuke Yamazaki has updated the pull request incrementally with one > additional commit since the last revision: > > Make heapify static src/java.base/share/classes/java/util/PriorityQueue.java line 312: > 310: // If a comparator is used, null must be rejected before it is > 311: // passed to the comparator. > 312: if (len == 1 || cmp != null) What's the reason for the `len == 1`-check (add comment) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31701#discussion_r3544694409
