On Tue, 14 Jul 2026 07:41:41 GMT, David Holmes <[email protected]> wrote:

>> Guanqiang Han has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Update -XshowSettings documentation
>
> test/jdk/tools/launcher/Settings.java line 331:
> 
>> 329:         TestResult tr = doExec(javaCmd,
>> 330:                                "-Duser.language=en",
>> 331:                                "-Duser.country=US",
> 
> Why do we need these?

They ensure English output because the test checks for "Usage: java". In a 
non-English environment, the usage text may be localized, causing the test to 
fail.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31891#discussion_r3577189713

Reply via email to