On Tue, 14 Jul 2026 08:16:23 GMT, Guanqiang Han <[email protected]> wrote:
>> src/java.base/share/native/libjli/java.c line 555:
>>
>>> 553: if (showSettings != NULL && what == NULL) {
>>> 554: LEAVE();
>>> 555: }
>>
>> Can't we do this back at line 501 after showing the settings?
>
> I think the check should remain at the current location. `what == NULL` only
> means that no application was specified; another launcher action may still
> need to run.
>
> For example, with `java -XshowSettings -version`, the version is printed
> later. Moving the check immediately after `CHECK_EXCEPTION_LEAVE(1);` would
> skip that output.
Thanks, I misunderstood the meaning of `what`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31891#discussion_r3578812888
