On Thu, 16 Jul 2026 18:24:58 GMT, Naoto Sato <[email protected]> wrote:

> Update the lowercasing logic for Greek capital sigma to use the "Final_Sigma" 
> condition. The current implementation still uses the "Final_Cased" condition 
> from Unicode 4.0.
> 
> This change also generates the `ConditionalSpecialCasing` entries and 
> Unicode-property predicates from the UCD, replacing manually maintained data 
> that was incomplete and out of date.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

make/jdk/src/classes/build/tools/generatespecialcasing/GenerateSpecialCasing.java
 line 42:

> 40:  * then reformats each entry into `Entry` instances in 
> `java.lang.ConditionalSpecialCasing` class.
> 41:  */
> 42: public class GenerateSpecialCasing {

Preferably describe the cli arguments in the class level spec so people don't 
have to dig through `main` for this information

make/jdk/src/classes/build/tools/generatespecialcasing/GenerateSpecialCasing.java
 line 81:

> 79:         return "        new Entry(%s, new char[]{%s}, new char[]{%s}, %s, 
> %s),"
> 80:            .formatted(
> 81:                e.codePoint().isEmpty() ? "" : "0x" + e.codePoint(),

A comma without an actual argument doesn't seem right, like:
`new Entry(, new char[]{}, new char[]{}, null, 0),`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31937#discussion_r3599031138
PR Review Comment: https://git.openjdk.org/jdk/pull/31937#discussion_r3599038688

Reply via email to