On Thu, 16 Jul 2026 21:27:47 GMT, Chen Liang <[email protected]> wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - CLI args explanation / code point check
>> - Merge branch 'master' into JDK-8133167-String-toLowerCase-Final-Sigma
>> - initial commit
>
> make/jdk/src/classes/build/tools/generatespecialcasing/GenerateSpecialCasing.java
> line 81:
>
>> 79: return " new Entry(%s, new char[]{%s}, new char[]{%s},
>> %s, %s),"
>> 80: .formatted(
>> 81: e.codePoint().isEmpty() ? "" : "0x" + e.codePoint(),
>
> A comma without an actual argument doesn't seem right, like:
> `new Entry(, new char[]{}, new char[]{}, null, 0),`
Good point. Although the code point cannot be empty (thus the isEmpty() check
was redundant), I added the check before formatting the entry.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31937#discussion_r3599281602
