On Thu, 16 Jul 2026 10:33:44 GMT, Arno Zeller <[email protected]> wrote:
> As far as I understand the seenPlugins will not contain exclude-files in case > it was disabled with --disable-plugin, because it was removed earlier from > the list or haven't been on the list by default. Semantically, there should be no difference. Thus, I'd prefer one less extra state to maintain. `seenPlugins` is guarded by `!Utils.isDisabled(plugin)`. That's what we want. > And regarding user added filtering options I would guess, it is ok to keep > the debuginfo filtering in case someone added an --exclude-files option on > the commandline - do you agree? Yes. These should essentially be equivalent (on Linux): $ jlink --exclude-files=**/bin/java,**.debuginfo --strip-native-debug-symbols=exclude-debuginfo-files --strip-java-debug-attributes --add-modules java.base --verbose --output ./build/java.base.jdk and $ jlink --exclude-files=**/bin/java --strip-debug --add-modules java.base --verbose --output ./build/java.base.jdk ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31690#discussion_r3603257434
