On Thu, 2 Jul 2026 09:16:12 GMT, Dušan Bálek <[email protected]> wrote:

>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/DefaultStripDebugPlugin.java
>  line 46:
> 
>> 44:     private static final String EXCLUDE_DEBUGINFO = 
>> "exclude-debuginfo-files";
>> 45:     private static final String EXCLUDE_FILES_PLUGIN = "exclude-files";
>> 46:     private static final String EXCLUDE_DEBUG_FILES_PATTERN = 
>> "**.debuginfo,**.diz";
> 
> Consider adding `**.dSYM/**` for macOS external symbols.

I decided to not add .dSYM because there is no native strip plugin for macOS 
(or Windows) at the moment. Otherwise we would have the inconsistency the other 
way around - stripping external debuginfo, but not internal one on macOS and 
Windows.
But I have no strong opinion about that and can add dSYM handling if it is 
prefered. It could be useful, as external debuginfo is the default build option 
AFAIK.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31690#discussion_r3512287436

Reply via email to