On Fri, 17 Jul 2026 11:49:14 GMT, Sholto <[email protected]> wrote: >> Did we want unit tests specifically for the new `toProlepticYear` method? Or >> are we happy with the coverage provided by the existing >> `dateTimesAroundBcCheckThreshold` checks? > > I also just wanted to confirm if `toProlepticYear` is the correct > nomenclature.
Thanks for your update, it looks good to me. I'll run your change on our CI. > Did we want unit tests specifically for the new toProlepticYear method? I don't think we need white-box tests for the helper method, the existing public API tests are sufficient. > I also just wanted to confirm if toProlepticYear is the correct nomenclature. I think this name is correct. We are taking the Gregorian era and year and convert it to the ISO proleptic year. That is how the converted java.time classes refer to the year. https://docs.oracle.com/en/java/javase/26/docs//api/java.base/java/time/LocalDate.html#getYear() https://docs.oracle.com/en/java/javase/26/docs//api/java.base/java/time/LocalDateTime.html#getYear() ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31808#discussion_r3604790679
