On Wed, 22 Jul 2026 19:09:24 GMT, Chen Liang <[email protected]> wrote:
>> A few fail-safe convenience methods added in #23548 are missing necessary >> null checks. In addition, the `PackageEntry` symbolic conversion and testing >> methods are not correctly rejecting `PackageDesc` representing the unnamed >> package, a deliberate choice when `PackageDesc` was added to Java. >> >> Luckily, these oversights can be easily fixed and verified with minor >> enhancements to existing tests. There are also accompanying minor doc >> enhancements about the situation. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains seven additional commits since > the last revision: > > - More coverage > - Merge branch 'master' of https://github.com/openjdk/jdk into > fix/cf-match-inconsistencies > - Stage > - Merge branch 'master' of https://github.com/openjdk/jdk into > fix/cf-match-inconsistencies > - Replicable pool states > - Wording tweak > - Match method null check and inconsistencies I think this is fine within the scope of the ClassFile API. However, the unnamed module is not mentioned anywhere in the `ModuleDesc` javadoc. ------------- Marked as reviewed by asotona (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/31925#pullrequestreview-4762742015
