Hi All,

This is a follow-up to JDK-8370691 (Float16Vector). As noted by 
@xuemingshen-oracle and @PaulSandoz in this review comment on PR #28002 
(https://github.com/openjdk/jdk/pull/28002#issuecomment-4568001440), the 
floating-point VECTOR_OP_OR fallback is a dead and semantically incorrect code 
path: it computes the bitwise OR on the widened float32 encoding (e.g. for 
Float16, Float16 → float32 → OR → Float16).

The public OR operator is VO_NOFP and is rejected on FP vectors, so this path 
was only reachable via the private OR_UNCHECKED op (which lacked VO_NOFP) and 
had no call sites. This change removes the dead code entirely. As per 
https://github.com/openjdk/jdk/pull/28002#issuecomment-4568642676, if an FP OR 
is needed later, it can be re-added with proper intrinsic support.

Kindly review and share your feedback.

Best Regards,
Jatin

---------
- [x] I confirm that I make this contribution in accordance with the [OpenJDK 
Interim AI Policy](https://openjdk.org/legal/ai).

-------------

Commit messages:
 - 8385616: [VectorAPI] Remove VectorOperators.OR fallback handling for 
floating point vectors

Changes: https://git.openjdk.org/jdk/pull/32119/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=32119&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8385616
  Stats: 15 lines in 6 files changed: 0 ins; 15 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/32119.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/32119/head:pull/32119

PR: https://git.openjdk.org/jdk/pull/32119

Reply via email to