On Tue, 4 Aug 2026 19:40:08 GMT, Paul Sandoz <[email protected]> wrote:
>> Hi All, >> >> This is a follow-up to JDK-8370691 (Float16Vector). As noted by >> @xuemingshen-oracle and @PaulSandoz in this review comment on PR #28002 >> (https://github.com/openjdk/jdk/pull/28002#issuecomment-4568001440), the >> floating-point VECTOR_OP_OR fallback is a dead and semantically incorrect >> code path: it computes the bitwise OR on the widened float32 encoding (e.g. >> for Float16, Float16 → float32 → OR → Float16). >> >> The public OR operator is VO_NOFP and is rejected on FP vectors, so this >> path was only reachable via the private OR_UNCHECKED op (which lacked >> VO_NOFP) and had no call sites. This change removes the dead code entirely. >> As per https://github.com/openjdk/jdk/pull/28002#issuecomment-4568642676, if >> an FP OR is needed later, it can be re-added with proper intrinsic support. >> >> Kindly review and share your feedback. >> >> Best Regards, >> Jatin >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Marked as reviewed by psandoz (Reviewer). Thanks @PaulSandoz and @xuemingshen-oracle for review and approvals. ------------- PR Comment: https://git.openjdk.org/jdk/pull/32119#issuecomment-5187616696
