On Fri, 31 Jul 2026 10:08:38 GMT, Paul Hübner <[email protected]> wrote:
>> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update existing UnsupportedClassFileVersion test with new message. >> Restore Versions.java as no change needed. > > src/hotspot/share/classfile/classFileParser.cpp line 162: > >> 160: #define JAVA_28_VERSION 72 >> 161: >> 162: #define JDK_VERSION (7 + >> (JVM_CLASSFILE_MAJOR_VERSION - JAVA_7_VERSION)) > > I feel a bit uneasy about having classfile arithmetic here, and then never > validating the output in the unit tests as we use wildcards. > > I would prefer to use `JDK_Version` for the error message, or to sanity test > that the output in the error message is in fact the version we expect. Thanks for looking at this @Arraying ! The arithmetic/output was validated manually. It didn't seem worthwhile jumping through hoops in the test to dynamically produce the current JDK version, but I will see what I can do. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32117#discussion_r3700364093
