On Sun, 2 Aug 2026 21:41:59 GMT, David Holmes <[email protected]> wrote:
>> src/hotspot/share/classfile/classFileParser.cpp line 162: >> >>> 160: #define JAVA_28_VERSION 72 >>> 161: >>> 162: #define JDK_VERSION (7 + >>> (JVM_CLASSFILE_MAJOR_VERSION - JAVA_7_VERSION)) >> >> I feel a bit uneasy about having classfile arithmetic here, and then never >> validating the output in the unit tests as we use wildcards. >> >> I would prefer to use `JDK_Version` for the error message, or to sanity test >> that the output in the error message is in fact the version we expect. > > Thanks for looking at this @Arraying ! The arithmetic/output was validated > manually. It didn't seem worthwhile jumping through hoops in the test to > dynamically produce the current JDK version, but I will see what I can do. Test updated ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32117#discussion_r3700391246
