On Sat, 1 Aug 2026 00:42:19 GMT, Shaojin Wen <[email protected]> wrote:
>> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >> commits since the last revision: >> >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> feature/class-is-class-or-interface-1 >> - More spec clarifications >> - Wording review from Joe >> - Update usage in Valhalla >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> feature/class-is-class-or-interface-1 >> - Simplify code >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> feature/class-is-class-or-interface-1 >> - Class.isClassOrInterface > > src/java.base/share/classes/java/lang/Class.java line 929: > >> 927: * Classes and interfaces are {@linkplain ##referencetype reference >> types}. >> 928: * They are derived from {@code class} files and can declare fields >> and >> 929: * methods. > > **[Suggestion]** The three `{@linkplain ##referencetype ...}` links (in > `isInterface()`, `isArray()`, and `isClassOrInterface()` Javadoc) reference > an anchor that does not exist in `Class.java`. The `<dfn>{@index "reference > type"}s</dfn>` at line 889 creates a search index entry only — `{@index}` > does not generate a linkable HTML `id`. No `id="referencetype"` attribute or > markdown heading producing that anchor exists anywhere in the file (the only > `id=` attributes are `hiddenClasses`, `implicitClasses`, and `nameFormat`). — > Failure scenario: the javadoc tool emits warnings on every build of > `java.base`, and the rendered API documentation has broken/unlinked > "reference types" text in three method descriptions. > > Consider adding an explicit anchor where the term is defined, e.g.: > > * collectively called <dfn>{@index "reference type"}s</dfn><a > id="referencetype"></a>, > > or replacing the `##referencetype` links with `{@linkplain #isPrimitive() > reference types}`. > > _— qwen3.8-max-preview via Qwen Code /review_ @wenshao AI generated code reviews are not permitted per the OpenJDK Interim Policy on Generative AI - https://openjdk.org/legal/ai ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32109#discussion_r3700808655
