On Fri, 7 Aug 2026 19:21:50 GMT, Dan Heidinga <[email protected]> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Cleanup and test case improvement
>
> src/hotspot/share/classfile/stackMapTable.cpp line 212:
>
>> 210: #define CHECK_NT CHECK_(VerificationType::bogus_type())
>> 211:
>> 212: VerificationType StackMapReader::parse_verification_type(u1* flags,
>> bool in_locals, TRAPS) {
>
> `in_locals` -> `parsing_locals`?
>
> A slightly bigger refactoring that would be clearer is:
>
> enum class ParseLoc : int {
> Stack,
> Locals
> };
>
> VerificationType StackMapReader::parse_verification_type(u1* flags, ParseLoc
> parse, TRAPS)
>
> And calls would use `ParseLocation::Stack` or `::Locals`.
I think `parsing_locals` is better here. ParseLoc.Stack wouldn't be used for
anything so a regular boolean should suffice in this case.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32242#discussion_r3738477851
